Skip to content

Implement arcsin and arccos in Numpy. #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2022
Merged

Implement arcsin and arccos in Numpy. #1054

merged 3 commits into from
Aug 29, 2022

Conversation

redbopo
Copy link
Contributor

@redbopo redbopo commented Aug 28, 2022

Finish arcsin and arccos part in issue 960.

@redbopo redbopo changed the title Issue 960 Implement arcsin and arccos in Numpy. Aug 28, 2022
@redbopo
Copy link
Contributor Author

redbopo commented Aug 29, 2022

cc @czgdp1807

czgdp1807
czgdp1807 requested changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just rename elemental_05 to elemental_06 to avoid conflicts with #1002. Once done I will approve and merge.

@czgdp1807 czgdp1807 enabled auto-merge (squash) August 29, 2022 15:07
@czgdp1807 czgdp1807 merged commit d79ad27 into lcompilers:main Aug 29, 2022
@redbopo redbopo deleted the issue-960 branch August 29, 2022 15:22
@czgdp1807 czgdp1807 mentioned this pull request Sep 2, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redbopo @czgdp1807